refactor tests and bug fixes #28
Conversation
| except botocore.exceptions.ClientError as error: | ||
| logging.error( | ||
| f"Could not find Data Quality Job Definition with name {job_definition_name}" | ||
| f"Could not find Data Quality Job Definition with name {job_definition_name}. Error {error}" | ||
| ) |
There was a problem hiding this comment.
What if, for some reason, boto3 fails with a different exception other than botocore.exceptions.ClientError
then it will silently fail
i think we should have one more except block below this
Eg:
try:
do some stuff
except botocore.exceptions.ClientError as error:
logging.error()
except:
logging.error("something else went wrong")
There was a problem hiding this comment.
Specific type of exceptions will go to block, otherwise it will throw exception as usual
Wont fail silently
RedbackThomson
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akartsky, surajkota The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* refactor tests and bug fixes * fix wait_resource * log describe error, increase delete timeout, refractor tests * add owners alias
* refactor tests and bug fixes * fix wait_resource * log describe error, increase delete timeout, refractor tests * add owners alias
3 participants
Description of changes
testing
using codebuild